fix(messagequeue): no retry after queue shutdown #38
+70
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we allowed the last message send attempt to run to maxRetries if the queue was shutdown, which also generated warning logs. Now, if a send attempt fails, check that the queue has shutdown and immediately return if it has
|
@Stebalien FYI this is something that's in go-bitswap that I'm sad to say somehow didn't make it over... eek! Sorry. @anorth this is the fix for the log messages... |
anorth
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Remove warning log messages, but also shutdown quickly without unneccesary send attempts
Implementation
Previously, we allowed the last message send attempt to run to maxRetries if the queue was shutdown, which also generated warning logs.
Now, if a send attempt fails, check that the queue has shutdownand immediately return if it has
Adds a test to replicate the failing behavior and verify the fix resolves it -- the test does involve use of time expiry, which is non-ideal, but probably there is nothing we can do until we have a mocked time in this repo.